Problem: Travis security on PRs break jobs

Solution: avoid using encrypted variables when on PR
buildout · Mar 12, 2021 · a7e4ad6 · a7e4ad6
1 parent d685efd
commit a7e4ad6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -64,7 +64,7 @@ notifications:
     - buildout-development@googlegroups.com
 
 script:
-    - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
+    - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then bash ./.travis/docker_login_on_non_pull_requests.sh; fi'
     - ./ci_build.sh
 
 env:

diff --git a/.travis/docker_login_on_non_pull_requests.sh b/.travis/docker_login_on_non_pull_requests.sh
@@ -0,0 +1 @@
+echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
diff --git a/news/travis-pr.develop b/news/travis-pr.develop
@@ -0,0 +1 @@
+Avoid broken jobs on Travis because of security on PRs