update-versions-file without `show-picked-version` #71

Closed
jaap3 opened this Issue Feb 14, 2013 · 2 comments

3 participants

@jaap3

buildout.dumppickedversions doesn't print the list of picked versions if an output file is given. I like that behavior but it's not possible with buildout 2.0.

Right now you have to set show-picked-versions = true for update-versions-file to work. (https://github.com/buildout/buildout/blob/master/src/zc/buildout/buildout.py#L999). (b.t.w. This is not documented clearly).

I suggest that if show-picked-versions = false but update-versions-file is set to a filename the file will get updated.

@reinout

Good point! This is a bug. Shouldn't be too hard to fix.

@reinout reinout added a commit to reinout/buildout that referenced this issue Feb 14, 2013
@reinout reinout Added test demonstrating #71
`update-versions-file = true` has no effect when `show-picked-versions` is
false.
4238697
@reinout

I've added a pull request #72 fixing this.

@cjw296 cjw296 pushed a commit that closed this issue Feb 14, 2013
@reinout reinout Fixed #71: when needed, write versions to file
Picked versions are stored for later printing/writing in the Installer
also when show-picked-versions is set to false but update-versions-file is set
to a file. Previously, show-picked-versions=false would also disable the versions
file updating.
7ebea29
@cjw296 cjw296 closed this in 7ebea29 Feb 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment