Lighten doc examples by using bobo rather than ZEO #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the tests more lightweight, because bobo is much smaller. To allow people without the ability to build extensions to follow along.
IDK why this didn't break tests before. :/
…sts ran, given some of the synamic test activation
|
LGTM overall. I would probably edit out the make-hating path integral via |
|
But I love to hate make :) But to make you happy.... Hm, what is this squash option... |
|
|
|
Thanks. Missed that the button was also a pulldown (I hate make ;) |
mgedmin
reviewed
Feb 24, 2017
|
|
||
| .. [#gcc] Currently, this example requires the ability to build | ||
| Python extensions and requires access to development tools. | ||
| characters as in ``bobo <3``, so they're separated by newlines. |
There was a problem hiding this comment.
Not consciously :) If I'd noticed it, I would have fixed the usage above too. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main reasons:
People can follow examples without needing a compiler
Make these tests run less slowly.
I considered using fake examples, but I think it's good that people can try the examples and have them work.
I took a stab toward enabling parallel execution using layers, but gave up, but I plan to circle back, because the buildout tests take too long to run.