Rename buildpack key to id for app image metadata label #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
requested review from
sclevine and
ekcasey
and removed request for
ekcasey
sclevine
approved these changes
Mar 4, 2019
Signed-off-by: Danny Joyce <djoyce@pivotal.io> Signed-off-by: Joao Pereira <jdealmeidapereira@pivotal.io>
djoyahoy
force-pushed
the
buildpack-key-to-id
branch
from
ba0ce3b
to
7fc7f46
Compare
|
Will this cause issues for apps already created which use the old key name? |
|
@sclevine Should I merge this? 🤷♂️ |
|
This is not an important change, so I'll close it. If it's important it will resurface again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.