Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 #1565

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Bump github.com/moby/buildkit from 0.11.6 to 0.12.5 #1565

merged 2 commits into from
Mar 25, 2024

Conversation

antoinerg
Copy link

@antoinerg antoinerg requested a review from a team as a code owner March 25, 2024 22:42
@tomkennedy513
Copy link
Collaborator

You can ignore the failing tests for building images. They are failing since the actions are running in a fork

@antoinerg
Copy link
Author

You can ignore the failing tests for building images. They are failing since the actions are running in a fork

That's too bad. I was hoping to trigger the e2e tests to make sure the changes are ✔️

cc @tomkennedy513

@tomkennedy513
Copy link
Collaborator

tomkennedy513 commented Mar 25, 2024

You can ignore the failing tests for building images. They are failing since the actions are running in a fork

That's too bad. I was hoping to trigger the e2e tests to make sure the changes are ✔️

cc @tomkennedy513

Ya we always intended on having a pr flow that would build the images to a local registry and then do e2e but never got around to getting it implemented. I'm ok merging, but I was just curious about those 2 new requires that were added.

@antoinerg
Copy link
Author

Ya we always intended on having a pr flow that would build the images to a local registry and then do e2e but never got around to getting it implemented. I'm ok merging, but I was just curious about those 2 new requires that were added.

I removed the block then ran go mod tidy again to produce b0d7900. They are new indirect dependencies!

go.mod Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.19%. Comparing base (68156a7) to head (b0d7900).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.13.x    #1565   +/-   ##
================================================
  Coverage            67.19%   67.19%           
================================================
  Files                  140      140           
  Lines                 8827     8827           
================================================
  Hits                  5931     5931           
  Misses                2389     2389           
  Partials               507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinerg
Copy link
Author

@tomkennedy513 thank you for the fast review. I'm not authorized to merge this pull request but please go ahead and merge it!

Is there a timeline for a new patch release of kpack that would include those changes?

Thanks again!

@tomkennedy513 tomkennedy513 merged commit 897858e into buildpacks-community:release/v0.13.x Mar 25, 2024
5 of 14 checks passed
@tomkennedy513
Copy link
Collaborator

tomkennedy513 commented Mar 25, 2024

@tomkennedy513 thank you for the fast review. I'm not authorized to merge this pull request but please go ahead and merge it!

Is there a timeline for a new patch release of kpack that would include those changes?

Thanks again!

I can release it when the pipeline finishes. can you also cherry pick these changes to main and open a PR?

@antoinerg antoinerg deleted the antoinerg/bump-buildkit branch March 25, 2024 23:03
@antoinerg
Copy link
Author

can you also cherry pick these changes to main and open a PR?

Absolutely! Please see #1566

@antoinerg
Copy link
Author

I can release it when the pipeline finishes.

Awesome! 🚀

@tomkennedy513
Copy link
Collaborator

I can release it when the pipeline finishes.

Awesome! 🚀

0.13.3 is released! thank you for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants