[Features Redesign] Update tab styling, layout #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
jromero
reviewed
Nov 30, 2021
| @@ -49,10 +49,6 @@ Leverage production-ready buildpacks maintained by the community. | |||
|
|
|||
| </div> | |||
|
|
|||
| ## Comparison | |||
|
|
|||
| {{< comparison-table >}} | |||
There was a problem hiding this comment.
Can we remove the file associated with this as part of this PR as well?
jromero
reviewed
Nov 30, 2021
Comment on lines
470
to
471
| <p></p> | ||
| <br /> |
There was a problem hiding this comment.
Why do we need this empty paragraph (<p>) and break (<br/>)?
There was a problem hiding this comment.
That was for the layout, to align the start of text with the left column, i'll make this cleaner with CSS :)
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
|
Made the changes :) |
jromero
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshita-Kanal harshita.kgv@gmail.com