deprecate stacks, add targets #582
Conversation
joe-kimmel-vmw
force-pushed
the
stackattack
branch
from
2bea529
to
59a5fa3
Compare
|
In answer to your question about https://buildpacks.io/docs/operator-guide/create-a-stack/, we should remove that. The docs should reflect the current best practice. I wonder if we should trust archive.org to store our legacy docs? Or should we have a Buildpacks API dropdown at the top? |
joe-kimmel-vmw
force-pushed
the
stackattack
branch
from
4affb50
to
0f35e40
Compare
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
…hade of beige Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
stackattack
branch
from
e90afcb
to
3803821
Compare
Probably safe -- it's not like a group of publishers would ever try to shut down the entire internet archive. |
joe-kimmel-vmw
changed the title
Co-authored-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
| ## What is a Target? | ||
|
|
||
| A target is the essential information about an operating system and architecture necessary to ensure that binaries will be placed in environments where they can execute successfully. | ||
| A buildpack may specify one or several targets. A build image or run image must specific one target. |
There was a problem hiding this comment.
This statement is confusing to me: A build image or run image must specific one target.. Does this mean [[targets]] is supposed to be nested inside the [run] and [build] blocks? I'm more familiar with yaml/json than with toml, so I tend to convert it in order to understand what is going on and it appears to be a builder-wide setting.
given this builder.toml:
[build]
image = "ghcr.io/jericop/build-jammy:target"
[run]
[[run.images]]
image = "ghcr.io/jericop/run-jammy:target"
[[targets]]
os = "linux"
arch = "amd64"
[[targets.distributions]]
name = "ubuntu"
versions = ["18.04", "20.04"]the yaml output is:
build:
image: ghcr.io/jericop/build-jammy:target
run:
images:
- image: ghcr.io/jericop/run-jammy:target
targets:
- os: linux
arch: amd64
distributions:
- name: ubuntu
versions:
- "18.04"
- "20.04"It would be helpful to have a complete example of using [[targets]] in a builder toml.
| Similarly | ||
|
|
||
| **Labels (optional)** | ||
|
|
||
| ##### TODO / question: I think the spec says that "the platform" (as opposed to the build image author) should set the labels? | ||
| https://github.com/buildpacks/spec/pull/335/files#diff-e603760990971da3f77be4bb8d77c3405098f006814fd8c054d2d15f395b8330R199 | ||
| should we mention them in this tutorial? | ||
| ##### end TODO /question | ||
|
|
||
|
|
There was a problem hiding this comment.
What direction is this taking? Can I help here?
There was a problem hiding this comment.
hmm. this is wrong as -is. the "image config" doesn't get the * but the labels do, i think. maybe I can ask @natalieparellano to confirm
There was a problem hiding this comment.
ah, so, we said, heck with it let's just not mention it in the tutorial since it's optional anyways, and only getting more optional as the spec gets closer and closer to being released.
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
|
Superseded by #618 |
a pass at revising our docs for targets. hopefully provides a starting point to refine them into something we all want to publish.
#422