Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default version of crane from 0.14.0 to 0.19.1 #262

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Mar 12, 2024

Since I just tried to use crane copy --all-tags with the version installed by the setup-tools action, however, it failed with:

Error: unknown flag: --all-tags

It turns out that feature was added in 0.15.0 in May 2023, but that version is still newer than the version installed by this action.

Whilst I can manually override the version myself, it seems we should update the default version to prevent others from running into similar footguns.

google/go-containerregistry@v0.14.0...v0.19.1

@edmorley edmorley requested review from a team as code owners March 12, 2024 22:43
Since I just tried to use `crane copy --all-tags` with the version installed
by the `setup-tools` action, however, it failed with:

```
Error: unknown flag: --all-tags
```

It turns out that feature was added in 0.15.0 in May 2023, but that
version is still newer than the version installed by this action.

Whilst I can manually override the version myself, it seems we should
update the default version to prevent others from running into
similar footguns.

google/go-containerregistry@v0.14.0...v0.19.1

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@edmorley edmorley changed the title Update default version of crane from 0.14.0 to 0.19.0 Update default version of crane from 0.14.0 to 0.19.1 Apr 8, 2024
@edmorley
Copy link
Contributor Author

edmorley commented Apr 8, 2024

@jkutner @jjbustamante I don't suppose someone could review? :-)

@jkutner jkutner added type:dependency-upgrade A dependency upgrade semver:minor A change requiring a minor version bump labels Apr 19, 2024
@jkutner jkutner enabled auto-merge April 19, 2024 12:51
@jkutner jkutner merged commit 110012f into buildpacks:main Apr 19, 2024
4 checks passed
@edmorley edmorley deleted the patch-1 branch April 19, 2024 13:02
@edmorley
Copy link
Contributor Author

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants