Add support for working-directory in launch.toml (API>=0.8) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcemaj
changed the title
gcemaj
changed the title
samj1912
added
type:enhancement
gcemaj
force-pushed
the
gcemaj-launch-working-dir
branch
from
ad0e745
to
8833a22
Compare
samj1912
reviewed
Apr 5, 2022
dmikusa
reviewed
Apr 5, 2022
gcemaj
force-pushed
the
gcemaj-launch-working-dir
branch
from
8833a22
to
0720848
Compare
Signed-off-by: gcemaj <gcemaj@bloomberg.net>
gcemaj
force-pushed
the
gcemaj-launch-working-dir
branch
from
0720848
to
5c5fb9c
Compare
samj1912
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for working directory setting in launch.toml
If API is not 0.8 then log that this setting will be ignored, and reset working directory to be blank. Otherwise ensure that the setting is propagated.
Closes #127