Add semver checks #134
Merged
Add semver checks #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samj1912
reviewed
Apr 5, 2022
samj1912
reviewed
Apr 5, 2022
samj1912
reviewed
Apr 5, 2022
gcemaj
force-pushed
the
gcemaj-semver
branch
2 times, most recently
from
d80d50e
to
b360265
Compare
samj1912
added
type:task
samj1912
reviewed
Apr 5, 2022
samj1912
reviewed
Apr 5, 2022
gcemaj
force-pushed
the
gcemaj-semver
branch
2 times, most recently
from
afdf252
to
e876a15
Compare
|
@gcemaj could you rebase and update the PR? |
samj1912
reviewed
Apr 7, 2022
samj1912
reviewed
Apr 7, 2022
Signed-off-by: gcemaj <gcemaj@bloomberg.net>
samj1912
approved these changes
Apr 7, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use semver for version checks instead of strings
Closes: #132