align toml tag of working-dir with spec
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/buildpacks/spec/blob/buildpack/v0.10/buildpack.md#launchtoml-toml Signed-off-by: Ralf Pannemans <ralf.pannemans@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com>
|
@dmikusa Maybe you can have a look. This is really small and clearly a bug imho since it contradicts the spec. |
|
No questions about the actual change, but I need to double-check this with someone on the Buildpacks team. The RFC calls for I see it was clearly changed, but it's unclear why it was changed, just that it was changed, buildpacks/spec@e3ba9c3. If you know more, please share. I'd like to know more cause I'm concerned with potential breaking changes. Conversation on Buildpacks Slack, if you'd like to follow, https://cloud-native.slack.com/archives/C0331B5QS02/p1701056869228749. |
dmikusa
added
type:bug
dmikusa
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/buildpacks/spec/blob/buildpack/v0.10/buildpack.md#launchtoml-toml
See also: same PR but for
2.xrelease #269