Do not enforce presence of CNB_STACK_ID #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com> Signed-off-by: Johannes Dillmann <j.dillmann@sap.com>
dmikusa
added
type:bug
dmikusa
approved these changes
Apr 19, 2024
|
All set. Thanks for this. Let me know when you want me to cut a release with this. I can do that anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CNB_STACK_IDis not present, the buildpacks should not just fail.related rfc: https://github.com/buildpacks/rfcs/blob/main/text/0096-remove-stacks-mixins.md
first step for fixing paketo-buildpacks/libpak#329
This also aligns the behavior with
packit, so that allpaketobuildpacks behave similar.Downport of #283