Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #0096] Rebaser should validate target data and update labels #744

Closed
Tracked by #219
buildpack-bot opened this issue Oct 6, 2021 · 0 comments · Fixed by #1056
Closed
Tracked by #219

[RFC #0096] Rebaser should validate target data and update labels #744

buildpack-bot opened this issue Oct 6, 2021 · 0 comments · Fixed by #1056
Labels
good first issue A good first issue to get started with.
Milestone
lifecycle 0.17.0

Comments

@buildpack-bot
Copy link
Member

buildpack-bot commented Oct 6, 2021 •
edited by natalieparellano
Loading

Spec PR: buildpacks/spec#335

On Platform API 0.12 or greater, the rebaser must ensure the following metadata matches for the old and new run images:

  • os (image config)
  • architecture (image config)
  • variant (image config, if specified)
  • io.buildpacks.distribution.name (image config label, if specified)
  • io.buildpacks.distribution.version (image config label, if specified)

These checks can be skipped if -force is passed (or CNB_FORCE_REBASE set)

The value of io.buildpacks.base.* labels SHALL be modified to that of the new run-image
@buildpack-bot buildpack-bot mentioned this issue Oct 6, 2021
Merged
@natalieparellano natalieparellano added this to the lifecycle-0.15.0 milestone Feb 25, 2022
@natalieparellano natalieparellano added the good first issue A good first issue to get started with. label Mar 30, 2022
@jromero jromero mentioned this issue May 18, 2022
Open
21 tasks
@natalieparellano natalieparellano removed this from the lifecycle-0.15.0 milestone Nov 3, 2022
@natalieparellano natalieparellano changed the title [RFC #0096] Rebaser should validate new run image metadata against old run image metadata [RFC #0096] Rebaser should validate target data and update labels Jan 9, 2023
@natalieparellano natalieparellano added this to the lifecycle 0.17.0 milestone Feb 6, 2023
@natalieparellano natalieparellano linked a pull request Mar 9, 2023 that will close this issue
Rebaser changes for run image extension #1032
Merged
@natalieparellano natalieparellano removed a link to a pull request Mar 28, 2023
Rebaser changes for run image extension #1032
Merged
@jabrown85 jabrown85 mentioned this issue Mar 30, 2023
Merged
@natalieparellano natalieparellano linked a pull request Apr 5, 2023 that will close this issue
0.12 Rebase Validation and Label Sync #1056
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with.
Projects
None yet
Milestone
lifecycle 0.17.0
Development

Successfully merging a pull request may close this issue.

0.12 Rebase Validation and Label Sync buildpacks/lifecycle
2 participants
@natalieparellano @buildpack-bot