0.12 Rebase Validation and Label Sync #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrown85
changed the title
rebaser.go
Outdated
| return errors.Wrap(err, "get new base image os") | ||
| } | ||
| if appOS != newBaseOS { | ||
| return fmt.Errorf("incompatible os: '%s' is not compatible with '%s'", newBaseOS, appOS) |
There was a problem hiding this comment.
nit here, and i think also applicable a few other places (even arch) we're doing an equality check but the word we're using is "compatible" -- so i could be an ubuntu-based distro that promises 100% compatibility, but if i list my os as "mint" or whatever then the string won't equal ubuntu ... and it's a nit b/c I'm not arguing we should be maintaining a detailed compatiblity table in the code, but I do think we should change the language to is not equal to so that it's more obvious to anyone confronting this error message that we're just doing the simplest thing
There was a problem hiding this comment.
Updated error message in f4092ea
For 0.12 and beyond, rebase is now validating the OS, Arch, Variant and io.buildpack labels specific to OS. This can be skipped with the --force flag. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
For platforms running 0.12 and beyond, copy the io.buildpacks.base.* labels to the new image on rebase. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
If the target image was built prior to 0.12, do not run the additional validation. This is because the validation is not backwards compatible with older images. Older images may not have the required fields and we don't want to force platforms to use the `--force` flag. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
force-pushed
the
jab/rebase-0.12-validation
branch
from
f0a88f5
to
bd6b6c6
Compare
natalieparellano
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #744