Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #0093] Remove Shell-Specific Logic - Buildpack API #870

Closed
Tracked by #222
mboldt opened this issue Jun 16, 2022 · 1 comment
Closed
Tracked by #222

[RFC #0093] Remove Shell-Specific Logic - Buildpack API #870

mboldt opened this issue Jun 16, 2022 · 1 comment
Assignees
@mboldt
Labels
status/triage type/enhancement New feature or request

Comments

@mboldt
Copy link
Contributor

mboldt commented Jun 16, 2022

This issue has been split from #693 to capture the Buildpack API side of RFC #0093 Remove Shell Processes. See buildpacks/spec#305 for details on the Buildpack API spec changes to be implemented.
@mboldt mboldt added status/triage type/enhancement New feature or request labels Jun 16, 2022
This was referenced Jun 16, 2022
Closed
Open
jabrown85 added a commit that referenced this issue Aug 4, 2022
@jabrown85
Allow new buildpack API to use new launch.toml format
afab1d7 
- Buildpacks using the newer buildpack API must use the new launch.toml format
- The older format is still allowed on older buildpack API versions

Issue: #870
@jabrown85 jabrown85 mentioned this issue Aug 4, 2022
Merged
natalieparellano added a commit that referenced this issue Aug 23, 2022
@jabrown85 @natalieparellano
Allow new buildpack API to use new launch.toml format (#889)
328f07b 
* Ignore .tool-versions for asdf and other tooling

* Allow new buildpack API to use new launch.toml format

- Buildpacks using the newer buildpack API must use the new launch.toml format
- The older format is still allowed on older buildpack API versions

Issue: #870

* Update buildpack/build_test.go

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>

* Update buildpack/build_test.go

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>

* Update buildpack/build_test.go

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>

* Added Buildpack 0.10 as valid buildpack API

Fixed tests that were now invalid due to the default buildpack being 0.10

Signed-off-by: Jesse Brown <jabrown85@gmail.com>

* Apply suggestions from code review

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member

Resolved by #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboldt mboldt

Labels
status/triage type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mboldt @natalieparellano