Ignore pax global header in tar extract #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Leong <benri@users.noreply.github.com>
benri
force-pushed
the
bl/archive-pax-global-header
branch
from
cebee1d
to
d409e5a
Compare
jabrown85
approved these changes
Mar 20, 2023
natalieparellano
pushed a commit
that referenced
this pull request
Mar 20, 2023
Ignore pax global header in tar extract
natalieparellano
added a commit
that referenced
this pull request
Mar 20, 2023
* Fix log message when run image not found (#1004) Before: "Previous image with name <run image name> not found" After: "Image with name <run image name> not found" Signed-off-by: Natalie Arellano <narellano@vmware.com> * Bump containerd (#1015) Signed-off-by: Natalie Arellano <narellano@vmware.com> * Replace print with logger in image_cache.go, fixes formatting (#1012) * Replace print with logger in image_cache.go, fixes formatting Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> * Add tests for image_cache logger Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> --------- Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> * Bump golang.org/x/net from 0.5.0 to 0.7.0 (#1017) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.5.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Merge pull request #1036 from benri/bl/archive-pax-global-header Ignore pax global header in tar extract * Bump golang.org/x/sys from 0.5.0 to 0.6.0 (#1029) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](golang/sys@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/containerd/containerd from 1.6.18 to 1.6.19 (#1040) * Bump github.com/containerd/containerd from 1.6.18 to 1.7.0 Signed-off-by: Natalie Arellano <narellano@vmware.com> * Only bump to 1.6.19 instead of 1.7.x until we can upgrade docker/docker docker/docker 20.10.23 is incompatible with containerd 1.7.x+ due to the removal of sys/userns_deprecated.go (upgrading containerd results in lifecycle compile errors like go/pkg/mod/github.com/docker/docker@v20.10.23+incompatible/pkg/archive/archive_unix.go:96:42: undefined: sys.RunningInUserNS) Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Harshal Mittal <harshalmittal4@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jesse Brown <jabrown85@gmail.com>
natalieparellano
added a commit
that referenced
this pull request
Mar 29, 2023
#1049) * Ready release/0.16.1 (#1041) * Fix log message when run image not found (#1004) Before: "Previous image with name <run image name> not found" After: "Image with name <run image name> not found" Signed-off-by: Natalie Arellano <narellano@vmware.com> * Bump containerd (#1015) Signed-off-by: Natalie Arellano <narellano@vmware.com> * Replace print with logger in image_cache.go, fixes formatting (#1012) * Replace print with logger in image_cache.go, fixes formatting Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> * Add tests for image_cache logger Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> --------- Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> * Bump golang.org/x/net from 0.5.0 to 0.7.0 (#1017) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.5.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Merge pull request #1036 from benri/bl/archive-pax-global-header Ignore pax global header in tar extract * Bump golang.org/x/sys from 0.5.0 to 0.6.0 (#1029) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](golang/sys@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/containerd/containerd from 1.6.18 to 1.6.19 (#1040) * Bump github.com/containerd/containerd from 1.6.18 to 1.7.0 Signed-off-by: Natalie Arellano <narellano@vmware.com> * Only bump to 1.6.19 instead of 1.7.x until we can upgrade docker/docker docker/docker 20.10.23 is incompatible with containerd 1.7.x+ due to the removal of sys/userns_deprecated.go (upgrading containerd results in lifecycle compile errors like go/pkg/mod/github.com/docker/docker@v20.10.23+incompatible/pkg/archive/archive_unix.go:96:42: undefined: sys.RunningInUserNS) Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Harshal Mittal <harshalmittal4@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jesse Brown <jabrown85@gmail.com> * Add sleep to "publish images" workflow (#1042) It takes a few seconds for the image to be available Signed-off-by: Natalie Arellano <narellano@vmware.com> * Fix buildpacksio/lifecycle manifest create (#1043) * Force lifecycle images to have docker media types Signed-off-by: Natalie Arellano <narellano@vmware.com> * Update go.mod to use latest imgutil Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> * Bump kaniko & docker and unpin deps (#1045) * Update kaniko & docker, unpin deps Signed-off-by: Natalie Arellano <narellano@vmware.com> * Update containerd Signed-off-by: Natalie Arellano <narellano@vmware.com> * Remove CVE ignores now that runc is unpinned Signed-off-by: Natalie Arellano <narellano@vmware.com> * Update to released kaniko Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> * Ignore non-impactful runc CVE (#1047) Signed-off-by: Natalie Arellano <narellano@vmware.com> * Fix unit Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Harshal Mittal <harshalmittal4@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jesse Brown <jabrown85@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pax global header headers is currently not handled, but it should not cause a failure with the side effect of not uncompressing an otherwise valid tarball.