extender: better uid checks and error if it stay as root #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrown85
approved these changes
May 17, 2023
10 tasks
joe-kimmel-vmw
force-pushed
the
extender_uid_checks
branch
from
b5d0e63
to
d8c6ca3
Compare
|
Looks good @joe-kimmel-vmw! Is it possible you could fix the DCO? I think you need to re-sign 92b3363 |
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com> updates to unit test Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
extender_uid_checks
branch
from
d8c6ca3
to
f0064e9
Compare
natalieparellano
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should resolve two bullet points on #1057