When checking read/write access, if there is no access, surface the e… #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror that occurred This can be helpful in debugging failed builds where access is expected Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
| return "", err | ||
| } | ||
| if ok { | ||
| if ok, _ := checkReadAccess(image, keychain); ok { |
There was a problem hiding this comment.
Ideally we'd log the error at this point, but that requires a logger, which is a bigger change
Signed-off-by: Natalie Arellano <narellano@vmware.com>
cmoulliard
reviewed
Jun 26, 2023
| if !img.CheckReadAccess() { | ||
| canRead, err := img.CheckReadAccess() | ||
| if !canRead { | ||
| cmd.DefaultLogger.Debugf("Error checking read access: %s", err) |
There was a problem hiding this comment.
We should log that without using Debug as some users using Tekton or kpack could not be aware about how to enable log level !!
| if !img.CheckReadWriteAccess() { | ||
| canReadWrite, err := img.CheckReadWriteAccess() | ||
| if !canReadWrite { | ||
| cmd.DefaultLogger.Debugf("Error checking read/write access: %s", err) |
There was a problem hiding this comment.
We should log that without using Debug as some users using Tekton or kpack could not be aware about how to enable log level !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rror that occurred
This can be helpful in debugging failed builds where access is expected