adds CNB_ORDER_PATH env var hint to error message when order.toml fil… #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e can't be found Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
detector-order-error-msg
branch
from
e3a68dd
to
f596c52
Compare
jabrown85
approved these changes
Jul 5, 2023
joe-kimmel-vmw
commented
Jul 5, 2023
| @@ -89,6 +91,9 @@ func ReadOrder(path string) (buildpack.Order, buildpack.Order, error) { | |||
| } | |||
| _, err := toml.DecodeFile(path, &order) | |||
| if err != nil { | |||
| if errors.Is(err, fs.ErrNotExist) { | |||
| return nil, nil, fmt.Errorf("failed to read order file: %w, Hint: Try setting env var CNB_ORDER_PATH to the path of a valid order.toml file", err) | |||
There was a problem hiding this comment.
note: there is actually a --order flag
|
Do we still want this one? I think we originally thought that the order path was a special case, but then we realized that it is also a flag (like the other paths). I'm going to put this in draft for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e can't be found
see: #1138