Require the CNB_PLATFORM_API env var to be set #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to (deprecated) version 0.3 Instead of defaulting to a newer Platform API version, which would silently change behavior for platforms that do not currently set this env var. Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
changed the title
natalieparellano
force-pushed
the
require-cnb-platform-api
branch
from
3acf107
to
c0b71c0
Compare
natalieparellano
force-pushed
the
require-cnb-platform-api
branch
2 times, most recently
from
514d6b6
to
a8846c5
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
require-cnb-platform-api
branch
from
a8846c5
to
9d46404
Compare
jabrown85
approved these changes
Jul 11, 2023
joe-kimmel-vmw
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
LGTM.
all the //nolints feel a little tragic but at a glance it looks like you can't use the skip-dirs directory for only one kind of linter.
so we could decide to just never lint our acceptance tests at all, but I think there's no granular way of saying "my acceptance tests should be allowed to pass unsanitized strings directly to the command line but please do all the other linty checks."
dlion
pushed a commit
to dlion/lifecycle
that referenced
this pull request
Jul 20, 2023
* Require the CNB_PLATFORM_API env var to be set, instead of defaulting to (deprecated) version 0.3 Instead of defaulting to a newer Platform API version, which would silently change behavior for platforms that do not currently set this env var. Signed-off-by: Natalie Arellano <narellano@vmware.com> * Fix acceptance Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of defaulting to (deprecated) version 0.3
Instead of defaulting to a newer Platform API version, which would silently change behavior for platforms that do not currently set this env var
First PR in support of https://github.com/buildpacks/rfcs/blob/main/text/0110-deprecate-apis.md