Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp logs for entry/exit for all the top-level Lifecycle package… #1160

Conversation

joe-kimmel-vmw
Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw commented Jul 26, 2023

… functions

See discussion in #1153

… functions

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw joe-kimmel-vmw requested a review from a team as a code owner July 26, 2023 01:09
log/timelog_test.go Outdated Show resolved Hide resolved
log/timelog_test.go Outdated Show resolved Hide resolved
@dlion
Copy link
Member

dlion commented Jul 26, 2023

Thanks Joe! I added a few comments 😄

analyzer.go Outdated Show resolved Hide resolved
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw joe-kimmel-vmw force-pushed the so-many-loggers-we-ran-out-of-flannel-shirts branch from 03762aa to 28c0253 Compare July 27, 2023 16:18
…such as unnecessary trailing newlines from being merged. Its about time somebody thought of the children.

Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw joe-kimmel-vmw merged commit f8b3419 into buildpacks:main Jul 27, 2023
7 checks passed
@joe-kimmel-vmw joe-kimmel-vmw deleted the so-many-loggers-we-ran-out-of-flannel-shirts branch July 27, 2023 20:48
@joe-kimmel-vmw joe-kimmel-vmw added this to the lifecycle 0.17.0 milestone Jul 27, 2023
joe-kimmel-vmw added a commit to joe-kimmel-vmw/lifecycle that referenced this pull request Jul 27, 2023
…s-we-ran-out-of-flannel-shirts

timestamp logs for entry/exit for all the top-level Lifecycle package…
@joe-kimmel-vmw joe-kimmel-vmw restored the so-many-loggers-we-ran-out-of-flannel-shirts branch July 27, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants