-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate mixins #639
Validate mixins #639
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
If you set aside the platform -> common changes (which I’m not in love with, because things like platform.LayersMetadata read better than common.LayersMetadata) the most substantive changes are - detector.go - I actually like how the code reads. My main concern is that it's an awful lot of code to write (for just analyzed.toml). I would love to hear what others think. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Received some good feedback in sub team sync - will take a stab at making this simpler. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Given that this validation is no longer needed, I'm going to close this PR. |
Resolves #578