Add verbose logging to Analyze and Build phases

Signed-off-by: David Freilich <dfreilich@vmware.com>
buildpacks · May 20, 2020 · 9654c17 · 9654c17
1 parent 45c26d2
commit 9654c17
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/internal/build/phases.go b/internal/build/phases.go
@@ -178,7 +178,7 @@ func (l *Lifecycle) newAnalyze(repoName, cacheName, networkMode string, publish,
 			WithEnv(fmt.Sprintf("%s=%d", builder.EnvUID, l.builder.UID()), fmt.Sprintf("%s=%d", builder.EnvGID, l.builder.GID())),
 			WithRegistryAccess(authConfig),
 			WithRoot(),
-			WithArgs(args...),
+			WithArgs(l.withLogLevel(args...)...),
 			WithNetwork(networkMode),
 			WithBinds(fmt.Sprintf("%s:%s", cacheName, cacheDir)),
 		)
@@ -215,9 +215,11 @@ func (l *Lifecycle) Build(ctx context.Context, networkMode string, volumes []str
 		"builder",
 		l,
 		WithArgs(
-			"-layers", layersDir,
-			"-app", appDir,
-			"-platform", platformDir,
+			l.withLogLevel(
+				"-layers", layersDir,
+				"-app", appDir,
+				"-platform", platformDir,
+			)...,
 		),
 		WithNetwork(networkMode),
 		WithBinds(volumes...),

diff --git a/internal/build/phases_test.go b/internal/build/phases_test.go
@@ -375,7 +375,7 @@ func testPhases(t *testing.T, when spec.G, it spec.S) {
 				h.AssertEq(t, configProvider.Name(), "analyzer")
 				h.AssertIncludeAllExpectedPatterns(t,
 					configProvider.ContainerConfig().Cmd,
-					//[]string{"-log-level", "debug"}, // TODO: fix [https://github.com/buildpacks/pack/issues/419].
+					[]string{"-log-level", "debug"},
 					[]string{"-layers", "/layers"},
 					[]string{expectedRepoName},
 				)
@@ -569,7 +569,7 @@ func testPhases(t *testing.T, when spec.G, it spec.S) {
 			h.AssertEq(t, configProvider.Name(), "builder")
 			h.AssertIncludeAllExpectedPatterns(t,
 				configProvider.ContainerConfig().Cmd,
-				//[]string{"-log-level", "debug"}, // TODO: fix [https://github.com/buildpacks/pack/issues/419].
+				[]string{"-log-level", "debug"},
 				[]string{"-layers", "/layers"},
 				[]string{"-app", "/workspace"},
 				[]string{"-platform", "/platform"},