Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short flag for builder in pack build #424

Closed
jromero opened this issue Dec 18, 2019 · 7 comments · Fixed by #437
Closed

Add short flag for builder in pack build #424

jromero opened this issue Dec 18, 2019 · 7 comments · Fixed by #437
Labels
size/sm Small level of effort status/discussion-needed Issue or PR that requires in-depth discussion.

Comments

@jromero
Copy link
Member

jromero commented Dec 18, 2019

As a developer, I'd like to be able to specify the builder using -b when calling pack build.

Why -b for builder and not buildpack? Most common use case is to specify a builder. Specifying a buildpack is more targeted towards an edge case for testing, troubleshooting or debugging.

@jromero jromero added size/sm Small level of effort status/discussion-needed Issue or PR that requires in-depth discussion. labels Dec 18, 2019
@sclevine
Copy link
Member

Most common use case is to specify a builder. Specifying a buildpack is more targeted towards an edge case for testing, troubleshooting or debugging.

I'm not sure if this will remain true with the introduction of buildpackage support, especially if we add a --from-builder flag that makes --buildpack easier to use with the buildpacks on the builder.

@thephw
Copy link

thephw commented Dec 18, 2019

I am inclined agree with @jromero, but I think that usage may depend on the web frameworks being built. For certain monolithic targets like Ruby on Rails you'll have more than one buildpack typically by default, but for more microservice targets you may have a single buildpack. Specifying the builder work well for both and takes advantage of the detect step.

Whats the context around buildpackage support?

@jromero
Copy link
Member Author

jromero commented Dec 18, 2019

RE: @sclevine

packages don't take away from the fact that pack needs a builder to build with. --buildpacks are optional and arguably ideal to omit in most workflows since you want the builder to detect the best option. (I think this leans a little on what @thephw has stated.)

Currently, the fact that you have to we rely on the use of state to improve UX, by calling set-default-builder, is less than ideal IMO. set-default-builder can be seen as a nice-to-have feature but not a prerequisite for any workflow.

@zmackie
Copy link
Contributor

zmackie commented Dec 20, 2019

What about -B? Having a short flag for both (buildpacks and builder) would be nice. I know buildpacks authors frequently use --buildpack x --buildpack Y --buildpack Z during testing.

So to summarize:

-B --builder
-b --buildpack

@jromero
Copy link
Member Author

jromero commented Dec 21, 2019

@Zanadar Interesting... The thought of case-insensitive Windows did come to mind but it seems like it might not be an issue. I like the proposal.

ktpv added a commit to ktpv/pack that referenced this issue Dec 28, 2019
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
@jromero
Copy link
Member Author

jromero commented Dec 30, 2019

@sclevine / @jkutner / @hone We've got a PR (#437) for @Zanadar's proposal to this issue. Any objections to this solution?

@jkutner
Copy link
Member

jkutner commented Dec 31, 2019

I'm fine with B and b. I agree with @sclevine that the use of --buildpack will become more common with buildpackages and a buildpack registry. The builder will usually be set as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/sm Small level of effort status/discussion-needed Issue or PR that requires in-depth discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants