Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unactionable error during builder validation #431

Closed
zmackie opened this issue Dec 20, 2019 · 1 comment
Closed

Unactionable error during builder validation #431

zmackie opened this issue Dec 20, 2019 · 1 comment
Labels
status/discussion-needed Issue or PR that requires in-depth discussion.

Comments

@zmackie
Copy link
Contributor

zmackie commented Dec 20, 2019

In debugging #430 I attempted to create a config with duplicate CNBs removed. However this caused issues with versions, I think.
I got this rather cryptic error:

ERROR: validating buildpacks: buildpack org.cloudfoundry.node-engine@0.0.124 not found on the builder.

It would be nice to have something actionable out of that error. It reads like something for a developer to debug, rather giving the user something to fix.

@zmackie zmackie changed the title Unclear output during builder validation Unactionable error during builder validation Dec 20, 2019
@jromero
Copy link
Member

jromero commented Dec 21, 2019

Related to #306.

This is UX concern. I am all in favor for it and would like to discuss what the best strategy would be.

We could look at them on a case-by-case basis or, preferably, create a strategy for providing assistive text.

Initial ideas:

  1. Create error types that could be asserted against at the cmd package and provide additional information there.
  2. Create error types that have assistive text built into them that is displayed as part of error.Error().

@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano natalieparellano added status/discussion-needed Issue or PR that requires in-depth discussion. and removed status/triage Issue or PR that requires contributor attention. labels Feb 5, 2020
@zmackie zmackie closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/discussion-needed Issue or PR that requires in-depth discussion.
Projects
None yet
Development

No branches or pull requests

3 participants