Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to documentation when errors occur #306

Open
dgageot opened this issue Sep 16, 2019 · 2 comments
Open

Add links to documentation when errors occur #306

dgageot opened this issue Sep 16, 2019 · 2 comments
Labels
good for mentorship A good issue for a mentorship project. help wanted Need some extra hands to get this done. roadmap/user-onboarding Help users (end-users, contributors, etc) get started with CNB. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.

Comments

@dgageot
Copy link
Member

dgageot commented Sep 16, 2019

While creating my builder with pack create-builder, I saw this error:

ERROR: validating buildpacks: buildpack my-stack.java@0.0.1 (Buildpack API version 0.1) is incompatible with lifecycle 0.4.0 (Buildpack API version 0.2)

However, I couldn't find any documentation that explains that api field should be set in buildpack.toml. If such documentation exists or is later on created, it would be nice to point at it in the warning.

@ekcasey
Copy link
Member

ekcasey commented Sep 17, 2019

The only reference in the docs currently is here https://buildpacks.io/docs/create-buildpack/building-blocks-cnb/.

It's purpose isn't well described, nor do we have a good documentation around which version of the buildpack interface / set of specified features are represented by buildpack API 0.1 vs 0.2. We should improve this.

@jromero
Copy link
Member

jromero commented Sep 21, 2019

However, I couldn't find any documentation that explains that api field should be set in buildpack.toml

Created buildpacks/docs#66 to address this.

If such documentation exists or is later on created, it would be nice to point at it in the warning.

This is something we don't currently do but it's an interesting idea. I personally like it. I know of certain CLI tools that do it and it works really well. A concern I can see being voiced would be broken links. We'd have to be more careful about changes to documentation locations or provide redirects when we do make changes. That seems like a minor set back to what the benefits could be.

danielleadams pushed a commit to buildpacks/docs that referenced this issue Oct 8, 2019
danielleadams pushed a commit to buildpacks/docs that referenced this issue Oct 8, 2019
buildpacks/pack#306, and makes api more explicit

Signed-off-by: Danielle Adams <danielle.adams@heroku.com>
@jromero jromero added status/discussion-needed Issue or PR that requires in-depth discussion. type/enhancement Issue that requests a new feature or improvement. labels Oct 9, 2019
@jromero jromero changed the title Couldn't find documentation on buildpack.toml's api field Add links to documentation when errors occur Oct 9, 2019
@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano natalieparellano removed the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@dfreilich dfreilich added good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/support Issue with general questions or troubleshooting. and removed status/discussion-needed Issue or PR that requires in-depth discussion. labels May 27, 2020
@jromero jromero added good for mentorship A good issue for a mentorship project. roadmap/user-onboarding Help users (end-users, contributors, etc) get started with CNB. and removed good first issue A good first issue to get started with. type/support Issue with general questions or troubleshooting. labels Sep 7, 2021
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good for mentorship A good issue for a mentorship project. help wanted Need some extra hands to get this done. roadmap/user-onboarding Help users (end-users, contributors, etc) get started with CNB. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

No branches or pull requests

5 participants