Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack report should not display error when config.toml is not present #433

Closed
jromero opened this issue Dec 21, 2019 · 0 comments · Fixed by #435
Closed

pack report should not display error when config.toml is not present #433

jromero opened this issue Dec 21, 2019 · 0 comments · Fixed by #435
Labels
good first issue A good first issue to get started with. size/sm Small level of effort type/enhancement Issue that requests a new feature or improvement.

Comments

@jromero
Copy link
Member

jromero commented Dec 21, 2019

Currently it seems misleading that we display an "error" when pack's config.toml is not present.

For example,

root@45fa57ec-7290-4959-619c-6c1af8ba6ada:/tmp/build/59a8880f# ./pack-cli/pack report
Pack:
  Version:  v0.6.0 (git sha: 109b629d388cec0ed3836b9fed6717727a9187c1)
  OS/Arch:  linux/amd64

Default Lifecycle Version:  0.5.0

Config:
(error: open /root/.pack/config.toml: no such file or directory)

Expected output:

root@45fa57ec-7290-4959-619c-6c1af8ba6ada:/tmp/build/59a8880f# ./pack-cli/pack report
Pack:
  Version:  v0.6.0 (git sha: 109b629d388cec0ed3836b9fed6717727a9187c1)
  OS/Arch:  linux/amd64

Default Lifecycle Version:  0.5.0

Config:
(no config file found at /root/.pack/config.toml)
@jromero jromero added good first issue A good first issue to get started with. size/sm Small level of effort type/enhancement Issue that requests a new feature or improvement. labels Dec 21, 2019
ktpv added a commit to ktpv/pack that referenced this issue Dec 26, 2019
@ktpv
fixes buildpacks#433
6d8c070 
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
ktpv added a commit to ktpv/pack that referenced this issue Dec 26, 2019
@ktpv
fixes buildpacks#433
751c364
@ktpv ktpv mentioned this issue Dec 26, 2019
Merged
ktpv added a commit to ktpv/pack that referenced this issue Dec 26, 2019
@ktpv
fixes buildpacks#433
4269184
ktpv added a commit to ktpv/pack that referenced this issue Dec 26, 2019
@ktpv
fixes buildpacks#433
373df90 
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
ktpv added a commit to ktpv/pack that referenced this issue Dec 26, 2019
@ktpv
fixes buildpacks#433 w/ windows separator
2be7d85 
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
ktpv added a commit to ktpv/pack that referenced this issue Dec 28, 2019
@ktpv
fixes buildpacks#433 w/ changes per code review
da8f211 
Signed-off-by: ktpv <ktpv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with. size/sm Small level of effort type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pack report should not display error when config.toml is not present ktpv/pack
1 participant
@jromero