Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --volume to support arbitrary target locations #764

Closed
jromero opened this issue Jul 23, 2020 · 0 comments · Fixed by #778
Closed

Update --volume to support arbitrary target locations #764

jromero opened this issue Jul 23, 2020 · 0 comments · Fixed by #778
Assignees
Labels
breaking-change Known to be non-backwards compatible good first issue A good first issue to get started with. type/enhancement Issue that requests a new feature or improvement.

Comments

@jromero
Copy link
Member

jromero commented Jul 23, 2020

Description

To enable further local experimentation and development for pack users of buildpacks, builders or lifecycles we would like to loosen the constraints on where volumes may be mounted with the possibility for those mounts to be writable.

Additionally, there has been feedback that the current implementation and it's automatic appending of /platform to the target location is surprising.

Proposed solution

This issue is a request to implement proposed solution as detail in buildpacks/rfcs#85.

Summary of changes:

  1. Allow --volume to support any target location
  2. Support a third colon mode parameter defaulting to ro. (eg. --volume=/tmp/dir:/some-dir:rw)
  3. WARN when a spec'd directory (aside from /platform) is targeted.

Additional context

@jromero jromero added type/enhancement Issue that requests a new feature or improvement. good first issue A good first issue to get started with. breaking-change Known to be non-backwards compatible status/blocked Issue or PR that is blocked. See comments. labels Jul 23, 2020
@jromero jromero removed the status/blocked Issue or PR that is blocked. See comments. label Aug 4, 2020
@jromero jromero self-assigned this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Known to be non-backwards compatible good first issue A good first issue to get started with. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant