-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arbitrary writable volume mounts during pack build
#778
Conversation
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 74.75% 74.74% -0.00%
==========================================
Files 77 77
Lines 5164 5174 +10
==========================================
+ Hits 3860 3867 +7
- Misses 999 1002 +3
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Javier Romero <rjavier@vmware.com>
Signed-off-by: Javier Romero <rjavier@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Should we have a warning that this may not work on other OSs?
|
||
func (i *PackInvoker) not0_11_0() bool { | ||
// laterThan returns true if pack version is older than the provided version | ||
func (i *PackInvoker) laterThan(version string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The only one I know of in which this may not work is Windows ( |
@jromero for WCOW, the solution would be fairly simple. Just use the |
@ameyer-pivotal Thank you. If I'm not mistaken this will be taken care of as part of #739 |
Summary
This PR adds support to volume mount at any location during
pack build
. It additionally adds support for writable mounts (rw
).Output
After
pack build --help
mounting a custom lifecycle
Documentation
Related
Resolves #764