Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If I interrupt the pack CLI at any point during execution, all Docker resources are cleaned up #86

Closed
sclevine opened this issue Jan 7, 2019 · 1 comment
Closed

If I interrupt the pack CLI at any point during execution, all Docker resources are cleaned up #86

sclevine opened this issue Jan 7, 2019 · 1 comment
Assignees
@joaopapereira
Labels
size/md Medium level of effort
Milestone
0.1.0

Comments

@sclevine
Copy link
Member

sclevine commented Jan 7, 2019

Context: https://pivotal.slack.com/archives/CCF45S0TF/p1546619392080900

Notes

  • Pack library should just take a channel and should not listen for SIGINT/SIGTERM
@sclevine sclevine created this issue from a note in Planning Board (Backlog) Jan 7, 2019
@sclevine sclevine added the size/md Medium level of effort label Jan 7, 2019
@matthewmcnew matthewmcnew moved this from Backlog to In Progress in Planning Board Jan 17, 2019
joaopapereira added a commit that referenced this issue Jan 24, 2019
@joaopapereira
Ensure kill cleans all containers running
f755177 
* Update spec version to 1.2.0

[#86]

Signed-off-by: Jacques Chester <jchester@pivotal.io>
@joaopapereira joaopapereira self-assigned this Jan 24, 2019
@joaopapereira joaopapereira moved this from In Progress to Done in Planning Board Jan 24, 2019
@sclevine
Copy link
Member Author

sclevine commented Feb 3, 2019

Looks good!

Note: if we want to get rid of the ERROR: run detect container: context canceled output when you ctrl-c, it's easy to detect that error code and return nil using the error-rewriting-in-defer pattern.

Also, we seem to be parsing some errors as format strings:

Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.38/containers/a59e96a44c4527e301f380dbae2c1495d6463ee666a2fee3dc61268b79dc5e7b/start: context canceled

Tagging with revisit, but accepting.

@sclevine sclevine moved this from Done to Release v0.1.0 in Planning Board Feb 3, 2019
@sclevine sclevine closed this as completed Apr 3, 2019
@jromero jromero added this to the 0.1.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaopapereira joaopapereira

Labels
size/md Medium level of effort
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@jromero @joaopapereira @sclevine