Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading whitespace in scripts generated by 'buildpack new' #1123

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

edmorley
Copy link
Contributor

Summary

Previously the bin/detect and bin/build bash scripts generated by pack buildpack new had a stray blank line as the first line of the script. This line has now been removed.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Previously the `bin/detect` and `bin/build` bash scripts generated
by `pack buildpack new` had a stray blank line as the first line of the
script. This line has now been removed.

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@edmorley edmorley requested a review from a team as a code owner March 30, 2021 17:15
@github-actions github-actions bot added this to the 0.18.0 milestone Mar 30, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Mar 30, 2021
@jromero jromero modified the milestones: 0.18.0, 0.19.0 Mar 30, 2021
@jromero jromero added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Mar 30, 2021
@jromero
Copy link
Member

jromero commented Mar 30, 2021

Thanks for the contribution! Keep it up!

@jromero jromero merged commit f6b7827 into buildpacks:main Mar 30, 2021
@edmorley edmorley deleted the buildpack-new-rm-whitespace branch March 30, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants