Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workspace mount point as option to build #1141

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Conversation

jkutner
Copy link
Member

@jkutner jkutner commented Apr 20, 2021

Summary

Allow the workspace directory to be configurable.

Output

Before

$ pack build ...

After

$ pack build --workspace app ...

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1121

@github-actions github-actions bot added this to the 0.19.0 milestone Apr 20, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 20, 2021
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
@jkutner jkutner marked this pull request as ready for review April 21, 2021 01:12
@jkutner jkutner requested a review from a team as a code owner April 21, 2021 01:12
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1141 (21a7929) into main (4d4f310) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   80.77%   80.80%   +0.03%     
==========================================
  Files         136      136              
  Lines        8289     8299      +10     
==========================================
+ Hits         6695     6705      +10     
  Misses       1164     1164              
  Partials      430      430              
Flag Coverage Δ
os_linux 80.29% <100.00%> (+0.08%) ⬆️
os_macos 77.82% <100.00%> (+0.07%) ⬆️
os_windows 80.71% <100.00%> (+0.03%) ⬆️
unit 80.29% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dwillist
Copy link
Contributor

dwillist commented Apr 26, 2021

@jkutner Hey thanks for the PR, any chance we could get some associated testing here at whatever level you're comfortable with? Codecov seems a little suspect 🤨

Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
@jkutner
Copy link
Member Author

jkutner commented Apr 27, 2021

@dwillist done

Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Happy to see this driven out, given the recent feedback on it. If you could just change the assertions in the test a bit to more accurately test the change, that would be 🤯

build.go Outdated Show resolved Hide resolved
internal/build/lifecycle_execution_test.go Outdated Show resolved Hide resolved
… workspace flag

Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich merged commit bfd0c73 into main Apr 28, 2021
@dfreilich dfreilich deleted the jkutner/fix-1121 branch April 28, 2021 08:13
@dfreilich dfreilich mentioned this pull request Apr 29, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support in buildpacks to change the location where all the source code gets copied.
3 participants