Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to lifecycle v0.11.3 #1187

Merged
merged 5 commits into from
May 26, 2021
Merged

Bump to lifecycle v0.11.3 #1187

merged 5 commits into from
May 26, 2021

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented May 17, 2021

Summary

Bump lifecycle to v0.11.3

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1169

@aemengo aemengo requested a review from a team as a code owner May 17, 2021 19:00
@github-actions github-actions bot added this to the 0.19.0 milestone May 17, 2021
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels May 17, 2021
aemengo
aemengo commented May 17, 2021
View reviewed changes
rebase.go Outdated Show resolved Hide resolved
@aemengo aemengo changed the title Fix lifecycle 0.11.3 package renames Bump to lifecycle v0.11.3 May 17, 2021
jromero
jromero suggested changes May 18, 2021
View reviewed changes
rebase.go Outdated Show resolved Hide resolved
inspect_image.go Outdated Show resolved Hide resolved
inspect_image_test.go Outdated Show resolved Hide resolved
internal/commands/inspect_image_test.go Outdated Show resolved Hide resolved
internal/inspectimage/writer/bom_json_test.go Show resolved Hide resolved
@dfreilich dfreilich mentioned this pull request May 19, 2021
Merged
2 tasks
dependabot bot and others added 2 commits May 19, 2021 13:51
@dependabot
Bump github.com/buildpacks/lifecycle from 0.10.2 to 0.11.3
f5a8fda 
Bumps [github.com/buildpacks/lifecycle](https://github.com/buildpacks/lifecycle) from 0.10.2 to 0.11.3.
- [Release notes](https://github.com/buildpacks/lifecycle/releases)
- [Changelog](https://github.com/buildpacks/lifecycle/blob/main/RELEASE.md)
- [Commits](buildpacks/lifecycle@v0.10.2...v0.11.3)

Signed-off-by: dependabot[bot] <support@github.com>
Fix lifecycle 0.11.3 package renames
e426093 
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
@aemengo aemengo force-pushed the fix-lifecycle-0.11.3-package-renames branch from abbf656 to 6cfaa7b Compare May 19, 2021 17:54
@codecov
Copy link

codecov bot commented May 19, 2021 •
edited

Codecov Report

Merging #1187 (2fd4158) into main (eb72b8a) will increase coverage by 0.06%.
The diff coverage is 43.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   80.86%   80.92%   +0.06%     
==========================================
  Files         136      136              
  Lines        8296     8283      -13     
==========================================
- Hits         6708     6702       -6     
+ Misses       1160     1156       -4     
+ Partials      428      425       -3
Flag Coverage Δ
os_linux 80.48% <47.23%> (+0.03%) ⬆️
os_macos 77.98% <47.23%> (+0.03%) ⬆️
os_windows 80.83% <43.48%> (+0.06%) ⬆️
unit 80.52% <47.23%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aemengo aemengo force-pushed the fix-lifecycle-0.11.3-package-renames branch from 6cfaa7b to d808ca3 Compare May 19, 2021 20:00
@jromero
Copy link
Member

jromero commented May 21, 2021 •
edited

Adding comment from slack:

TLDR; It looks like an actual error from the branch changes not the worker.

Recreated the WCOW worker based on the assumption that it was the worker due to what looked like a low-level error. After recreation the errors are still present.

ERROR: saving image: failed to write image to the following tags: [10.32.101.130:65324/simple-layers-package-image-buildpack-kspcaxug: loading image “10.32.101.130:65324/simple-layers-package-image-buildpack-kspcaxug”. first error: embedded daemon response: re-exec error: exit status 1: output: hcsshim::ImportLayer - failed failed in Win32: The configuration registry database is corrupt. (0x3f1)]

Afterwards, I reran the tests on a different branch and the errors are not present. That leads me to believe that a change in this branch broke something.

PR fixes
1d0325b 
• group imports according to style guide
• specify latest supported platformAPIVersion, during rebase
• update references to old lifecycle version

Signed-off-by: Anthony Emengo <aemengo@vmware.com>
@aemengo aemengo force-pushed the fix-lifecycle-0.11.3-package-renames branch from d808ca3 to 1d0325b Compare May 21, 2021 20:29
Micah Young and others added 2 commits May 24, 2021 13:37
Adds new imgutil NewImage constructor for OS
0a54eca 
Signed-off-by: Micah Young <ymicah@vmware.com>
Fix formatting
2fd4158 
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
@aemengo
Copy link
Contributor Author

aemengo commented May 24, 2021

@jromero Apologies, I did introduce failures on the wcow runner with this PR.

I pulled in a commit from @micahyoung that should address these failures.

dfreilich
dfreilich approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dfreilich dfreilich merged commit 360dbae into buildpacks:main May 26, 2021
@aemengo aemengo mentioned this pull request Jun 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero requested changes

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aemengo @jromero @dfreilich