Use lifecycle image that matches builder platform #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
github-actions
bot
added
the
type/enhancement
Codecov Report
@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 80.94% 80.96% +0.02%
==========================================
Files 136 136
Lines 8313 8316 +3
==========================================
+ Hits 6728 6732 +4
+ Misses 1159 1158 -1
Partials 426 426
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
aemengo
force-pushed
the
fix-pack-build-arm-failures
branch
from
e52e41a
to
70888d3
Compare
jromero
suggested changes
Jun 28, 2021
* Remove TODO statement Signed-off-by: Anthony Emengo <aemengo@vmware.com>
jromero
changed the title
jromero
added
type/bug
jromero
approved these changes
Jun 29, 2021
|
馃 Thank you for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fetches a lifecycle image that is the same platform as the requested builder image, when this builder is untrusted.
This PR also includes a refactor the
image.Fetch()method signature. This was done so that future modifications may not involve changes in so many files.Documentation
Caveats
Full disclosure: I don't have an arm machine, so I've never seen this work 馃槵
Related
Resolves #1197