Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite Existing Buildpacks #1362

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Overwrite Existing Buildpacks #1362

merged 5 commits into from
Feb 3, 2022

Conversation

dfreilich
Copy link
Member

Summary

Merges in #1336 (needed to update with latest)

@dfreilich dfreilich requested a review from a team as a code owner January 24, 2022 15:32
@github-actions github-actions bot added this to the 0.24.0 milestone Jan 24, 2022
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 24, 2022
@dfreilich dfreilich changed the title Update 1336 Overwrite Existing Buildpacks Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1362 (521697a) into main (9402d07) will decrease coverage by 1.23%.
The diff coverage is 51.79%.

❗ Current head 521697a differs from pull request most recent head 4d2f273. Consider uploading reports for the commit 4d2f273 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   81.47%   80.24%   -1.22%     
==========================================
  Files         148      148              
  Lines        9598     9654      +56     
==========================================
- Hits         7819     7746      -73     
- Misses       1313     1434     +121     
- Partials      466      474       +8     
Flag Coverage Δ
os_linux 80.03% <51.79%> (-0.13%) ⬇️
os_macos 77.43% <51.79%> (-0.12%) ⬇️
os_windows 80.08% <51.79%> (-1.25%) ⬇️
unit 80.24% <51.79%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero
Copy link
Member

jromero commented Jan 26, 2022

Some Windows WCOW tests appear to be genuinely failing. :(

@dfreilich dfreilich force-pushed the Update-1336 branch 2 times, most recently from 0831980 to 5f410ba Compare February 1, 2022 20:55
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Feb 2, 2022
fatiiates and others added 5 commits February 3, 2022 21:14
…the builder correctly

Signed-off-by: fatih <fatiiates@gmail.com>
Signed-off-by: fatih <fatiiates@gmail.com>
…ilure

Signed-off-by: David Freilich <david.freilich@appsflyer.com>
Signed-off-by: David Freilich <david.freilich@appsflyer.com>
Signed-off-by: David Freilich <david.freilich@appsflyer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants