flags: Add --cache flag for build cache as image
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
from
b49c9d2
to
0d389f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
+ Coverage 81.28% 81.37% +0.10%
==========================================
Files 151 152 +1
Lines 9778 9864 +86
==========================================
+ Hits 7947 8026 +79
- Misses 1355 1361 +6
- Partials 476 477 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
from
5a1ed76
to
dc5a9a3
Compare
github-actions
bot
added
the
type/chore
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
2 times, most recently
from
4545a12
to
8fe74b3
Compare
jromero
reviewed
Jul 5, 2022
jromero
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Agree with @dfreilich. This is looking really good.
I'm assuming that this PR will handle issues #1457 and #1475. If so, should we update the description to reflect that?
- Add `flag` definition - Integrate flag options with image cache - Add tests for flag options Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
- Add unit and acceptance tests Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
4 times, most recently
from
503888d
to
44f55dc
Compare
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
from
44f55dc
to
9cbc4b7
Compare
- Gate acceptance tests to work only when pack supports `--cache` - string constants for cache type and cache format has been moved to enums - Fix test cases, update acceptance test helper methods - Add new unit tests Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
imnitishng
force-pushed
the
cache-flag/build-image-cache
branch
from
9cbc4b7
to
c1deb54
Compare
jromero
approved these changes
Jul 12, 2022
✅ Acceptance✅ Keep existing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--cacheflag for configuring build and launch cache as image.pack build --cache 'type=build;format=image;name=<image name/image registry address>'Summary
Output
Before
After
Documentation
Related
Resolves #1475
Resolves #1457