fix: do not use docker's dilaler if URL contains path #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Vasek <mvasek@redhat.com>
github-actions
bot
added
the
type/enhancement
|
@starksm64 could you try this out? |
matejvasek
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
==========================================
+ Coverage 81.13% 81.14% +0.01%
==========================================
Files 155 155
Lines 10084 10086 +2
==========================================
+ Hits 8181 8183 +2
Misses 1420 1420
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. |
hone
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the ssh connection string includes path do not use standard docker dialer.
resolves #1511