Do not initialize http.Client during each request to a remote location
#2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
pbusko
force-pushed
the
blob-downloader-client
branch
from
aee1641
to
4fe503e
Compare
Signed-off-by: Pavel Busko <pavel.busko@sap.com>
pbusko
force-pushed
the
blob-downloader-client
branch
from
4fe503e
to
cfcd3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of initialising the
http.Clientduring every call to thedownloader.Download, use thehttp.DefaultClient. Also custom client can be provided with theblob.WithClientoption (for example with a customRoundTripperfor injecting credentials)Output
Before
After
Documentation
Related
Resolves #___