Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn misconfiguration keys in project.toml only for tables we own #2155

Merged

Conversation

jjbustamante
Copy link
Member

Summary

With pack PR 2042 we added a warning message when unsupported keys are declared in project.toml, the problem was that our spec allow the end-users to extend the file outside all non-_ table and this shouldn't print a warning

Output

Before

Any project.toml version 0.1 or 0.2 with something like declared

[unsupported-table]
unsupported-key = "some value"

Will print a warning message

After

We will only print a warning message for keys under _.* that are not supported or if buildpack.io is being used and not valid, everything else will be ignore

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1922

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 15, 2024
@github-actions github-actions bot added this to the 0.34.0 milestone May 15, 2024
pkg/project/project.go Outdated Show resolved Hide resolved
pkg/project/project.go Outdated Show resolved Hide resolved
… for tables in the project.toml we own

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the bugfix/jjbustamante/issue-1922 branch from 9c95d67 to f733a3a Compare May 17, 2024 11:18
@jjbustamante jjbustamante marked this pull request as ready for review May 17, 2024 11:19
@jjbustamante jjbustamante requested review from a team as code owners May 17, 2024 11:19
jjbustamante and others added 2 commits May 20, 2024 08:17
@jjbustamante jjbustamante merged commit 302963e into buildpacks:main May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack silently fails to use project.toml if the schema-version is not specified
3 participants