Print errors to stderr #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
force-pushed
the
fix/432-stderr
branch
from
14504c2
to
073b18d
Compare
Signed-off-by: Javier Romero <root@jromero.codes>
jromero
force-pushed
the
fix/432-stderr
branch
from
073b18d
to
cb29a62
Compare
Signed-off-by: Javier Romero <root@jromero.codes>
jromero
commented
Dec 29, 2019
| type WithInfoErrorWriter interface { | ||
| InfoErrorWriter() io.Writer | ||
| // WithSelectableWriter is an optional interface for loggers that want to support a separate writer per log level. | ||
| type WithSelectableWriter interface { |
There was a problem hiding this comment.
Condensed two interfaces into one to increase robustness and in my opinion provide additional clarity. e.g. GetInfoErrorWriter was confusing.
murphybytes
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #432