Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudfoundry/cnb:tiny to suggested builders #457

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Add cloudfoundry/cnb:tiny to suggested builders #457

merged 1 commit into from
Jan 15, 2020

Conversation

bstick12
Copy link

Suggested builder should include the cloudfoundry:cnb:tiny builder.

Suggested builders:
	Cloud Foundry:     cloudfoundry/cnb:bionic         Ubuntu bionic base image with buildpacks for Java, NodeJS and Golang
	Cloud Foundry:     cloudfoundry/cnb:cflinuxfs3     cflinuxfs3 base image with buildpacks for Java, .NET, NodeJS, Python, Golang, PHP, HTTPD and NGINX
	Cloud Foundry:     cloudfoundry/cnb:tiny           Tiny base image (bionic build image, distroless run image) with buildpacks for Golang
	Heroku:            heroku/buildpacks:18            heroku-18 base image with buildpacks for Ruby, Java, Node.js, Python, Golang, & PHP

Tip: Learn more about a specific builder with:
	pack inspect-builder [builder image]

@bstick12 bstick12 requested a review from a team as a code owner January 15, 2020 11:37
Add cloudfoundry/cnb:tiny to suggested builders
fcab91b 
Signed-off-by: Brendan Nolan <bnolan@pivotal.io>
jromero
jromero approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the contribution!

@jromero jromero added this to the pack-0.7.0 milestone Jan 15, 2020
@jromero jromero merged commit 75dbbc6 into buildpacks:master Jan 15, 2020
@jromero jromero added this to In Review in Planning Board via automation Jan 15, 2020
@jromero jromero moved this from In Review to Ready to Accept in Planning Board Jan 15, 2020
@zmackie zmackie moved this from Ready to Accept to Ready to Release in Planning Board Jan 15, 2020
@zmackie
Copy link
Contributor

zmackie commented Jan 15, 2020

Accepted:

 2020-01-15 16:18:20 ⌚  gke_cf-build-service-dev-219913_us-central1-a_annas-cluster beverley in ~/workspace/pack
± zm |master U:1 ✗| → ./out/pack suggest-builders
Suggested builders:
	Cloud Foundry:     cloudfoundry/cnb:bionic         Ubuntu bionic base image with buildpacks for Java, NodeJS and Golang
	Cloud Foundry:     cloudfoundry/cnb:cflinuxfs3     cflinuxfs3 base image with buildpacks for Java, .NET, NodeJS, Python, Golang, PHP, HTTPD and NGINX
	Cloud Foundry:     cloudfoundry/cnb:tiny           Tiny base image (bionic build image, distroless run image) with buildpacks for Golang
	Heroku:            heroku/buildpacks:18            heroku-18 base image with buildpacks for Ruby, Java, Node.js, Python, Golang, & PHP

Tip: Learn more about a specific builder with:
	pack inspect-builder [builder image]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Planning Board
  
Ready to Release
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bstick12 @zmackie @jromero