remove md from register buildpack issue body #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
=======================================
Coverage 73.52% 73.52%
=======================================
Files 75 75
Lines 5135 5135
=======================================
Hits 3775 3775
Misses 1043 1043
Partials 317 317
|
Signed-off-by: Travis <longoria.public@gmail.com>
elbandito
force-pushed
the
remove_md_regbp_template
branch
from
9876d4b
to
7c16dc3
Compare
dfreilich
approved these changes
Jul 14, 2020
| @@ -17,7 +17,7 @@ type Buildpack struct { | |||
| } | |||
|
|
|||
| // Validate that a buildpack reference contains required information | |||
| func (b *Buildpack) Validate() error { | |||
| func Validate(b Buildpack) error { | |||
There was a problem hiding this comment.
Suggested change
| func Validate(b Buildpack) error { | |
| func Validate (b Buildpack) error { |
I'm working on the corresponding Github Action effort to consume/process these issues - I don't want to have to deal with parsing multiple format types, especially if not necessary. |
|
UA: Made gh issue with config which looks like: |
jromero
approved these changes
Jul 16, 2020
jromero
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unnecessary md formatting for something that is intended to be machine parse-able. The only requirement is that it's TOML. Also added a small clean-up.
Output
id = "projectriff/java-function"
version = "0.4.2"
addr = "gcr.io/projectriff/java-function@sha256:aeab8d5b5cfa4d06fa0a099a1ebf26ad953c146d79a845f9283dac3986e8cf1e"
Before
Data
After
id = "projectriff/java-function"
version = "0.4.2"
addr = "gcr.io/projectriff/java-function@sha256:aeab8d5b5cfa4d06fa0a099a1ebf26ad953c146d79a845f9283dac3986e8cf1e"
Documentation
Related
Resolves #___