-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create yank-buildpack command #754
Conversation
94431ce
to
aa87ad3
Compare
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 73.53% 73.67% +0.15%
==========================================
Files 75 77 +2
Lines 5103 5184 +81
==========================================
+ Hits 3752 3819 +67
- Misses 1037 1048 +11
- Partials 314 317 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
5a43b45
to
58fb548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but overall this is great! Definitely appreciate the efforts at testing in this one
@elbandito, @dfreilich left a few comments. I'm eager to run through acceptance to get this in but want to wait for those conversations to be resolved so that it doesn't happen in vain if a few things might change. Let me know if I should proceed anyway. |
Thanks for the comments @dfreilich! |
44cb2a9
to
fd6493f
Compare
@jromero I made some changes. It's now ready for you to run some UA tests. |
Signed-off-by: Travis <longoria.public@gmail.com>
fd6493f
to
a5b126c
Compare
@elbandito I'm not sure if you've seen some minor unresolved test related comments from @dfreilich (they may be hidden by default in the GitHub UI). Going to start UA, just thought I'd mention it in case they were missed. |
@dfreilich did you have anything else you'd like for me to address before approving? I did pass on the godoc nits for this PR, but happy to look into them later. |
@elbandito It generally looks great. If you could add a test or two for |
Signed-off-by: Travis <longoria.public@gmail.com>
76b1fa7
to
89070d4
Compare
@dfreilich sorry, must have missed that comment. The test has been added. |
Summary
**NOTE: In the RFC, there is mention of 2 types to support: github and git. This PR is ONLY for supporting github.
This PR introduces the new
pack yank-buildpack
command (hidden behind the experimental flag). This command is used to update a previously registered buildpack asyanked
inside the Github registry . If the user wants to undo a previously yanked buildpack from the registry, they can use the--undo
flag. In both cases, the command will open a new browser window to create/submit a Github Issue (see below).> pack yank-buildpack heroku/rust@1.2.3
> pack yank-buildpack heroku/rust@1.2.3 --undo
Output
For more details on the flow of this command and how it's used, see the RFC.
Documentation
Related
Resolves #___