Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated flags #762

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Remove deprecated flags #762

merged 1 commit into from
Jul 23, 2020

Conversation

dfreilich
Copy link
Member

Signed-off-by: David Freilich dfreilich@vmware.com

Summary

Output

Before

Screen Shot 2020-07-23 at 12 24 18 PM

After

image

Related

Resolves #694

@dfreilich dfreilich requested a review from a team as a code owner July 23, 2020 16:25
* In #691, we deprecated builder-config and package-config flags in favor of --config. This removes those deprecated flags

Signed-off-by: David Freilich <dfreilich@vmware.com>
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #762 into main will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   73.67%   73.52%   -0.14%     
==========================================
  Files          75       75              
  Lines        5122     5112      -10     
==========================================
- Hits         3773     3758      -15     
- Misses       1036     1039       +3     
- Partials      313      315       +2     
Flag Coverage Δ
#os_linux 76.02% <ø> (-0.11%) ⬇️
#os_macos 71.89% <ø> (-0.07%) ⬇️
#os_windows 71.88% <ø> (-0.11%) ⬇️
#unit 73.52% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jromero jromero added breaking-change Known to be non-backwards compatible type/enhancement Issue that requests a new feature or improvement. labels Jul 23, 2020
@jromero jromero added this to the 0.13.0 milestone Jul 23, 2020
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dfreilich dfreilich merged commit 5c7a693 into main Jul 23, 2020
@dfreilich dfreilich deleted the fix/694-standardize-config branch July 23, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Known to be non-backwards compatible type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non-standard config params
3 participants