-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inspect-builder
output
#769
Improve inspect-builder
output
#769
Conversation
- by default show all id/version information for nested buildpacks - allow a '--depth' or '-d' flag to truncate this nesting at a configurable depth - clean up the 'Buildpacks:' list to omit repetitions with the same buildpack id and version Signed-off-by: dwillist <dthornton@vmware.com>
- allow for recursive structure of buildpacks as it is possible to create Signed-off-by: dwillist <dthornton@vmware.com>
6a551aa
to
e6f5f5f
Compare
Codecov Report
@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 74.76% 74.96% +0.20%
==========================================
Files 77 77
Lines 5174 5274 +100
==========================================
+ Hits 3868 3953 +85
- Misses 1001 1011 +10
- Partials 305 310 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
e6f5f5f
to
9d2409b
Compare
…nhancement Signed-off-by: dwillist <dthornton@vmware.com>
9d2409b
to
71f7c48
Compare
Signed-off-by: dwillist <dthornton@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thanks for the PR! I have a few nits and comments, but overall this is 🏅
One general question - looking at this, it's interesting that a lot of the legwork for inspect_builder
happens in internal/commands
, which seems to buck the normal trend of having it be part of the public API. I wonder what people think of moving this functionality to the public inspect_builder.go
file.
- update unit test names, - refactor detectionOrderOutput into understandable functions - remove un-needed homepage case Signed-off-by: dwillist <dthornton@vmware.com>
5a3f21d
to
252e834
Compare
Signed-off-by: dwillist <dthornton@vmware.com>
f685dd9
to
d1776b9
Compare
@dwillist sorry for the delay in reviewing this. Based on the output from the description of this issue I have two questions.
|
- alter how groups are counted Signed-off-by: dwillist <dthornton@vmware.com>
4d8f7f2
to
26ce9c0
Compare
Signed-off-by: dwillist dthornton@vmware.com
Summary
This lets the
inspect-builder
subcommand recursively list all group and buildpack information for a builder.The old behavior can still be achieved with
pack inspect-builder --depth 1
Additionally updates the
inspect-builder
output underBuildpacks:
to omit repetitions.Output
Before
We did not display
Detection Order
information for metabuildpacks.After
We can display Detection order to the desired depth using
--depth
flag, omission displays everything. Additionally theread/env
buildpack entry is no longer repeated.Example
pack inspect-builder <builder-name>
Example using the
--depth
flagpack inspect-builder <builder-name> --depth 2
Documentation
This will require documenting the new
--depth
flag that can be passed toinspect-builder
Related
Resolves #253