Do-Not-Merge: Use default keychain to authenticate image pulls #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is quite ugly but I've tested this change successfully against a Docker image in a private repository and against GCR. |
fbiville
commented
Dec 11, 2018
| tokenAtoms := strings.SplitN(string(tokenBytes), ":", 2) | ||
| rc, err := d.ImagePull(context.Background(), ref, dockertypes.ImagePullOptions{ | ||
| RegistryAuth: base64.StdEncoding.EncodeToString([]byte( | ||
| fmt.Sprintf(`{"username": "%s", "password": "%s"}`, |
There was a problem hiding this comment.
based on moby/moby#34503 (comment)
fbiville
commented
Dec 11, 2018
| reference, _ := name.ParseReference(ref, name.WeakValidation) | ||
| authenticator, _ := authn.DefaultKeychain.Resolve(reference.Context().Registry) | ||
| encodedHeader, _ := authenticator.Authorization() | ||
| encodedToken := strings.Replace(encodedHeader, "Basic ", "", 1) |
There was a problem hiding this comment.
based on moby/moby#34503 (comment)
|
This should not be merged as there is, I hope, a more robust approach or at least similar library code that does what this change does. |
|
Our docker pull code moved to The implementation is very similar to the one you contributed. |
|
Great news, @ekcasey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.