Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference paketo stacks in suggest-stacks #781

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

martyspiewak
Copy link
Contributor

Summary

Replace Cloud Foundry stacks with Paketo stacks

Output

pack suggest-stacks

Before

Stacks maintained by the community:

    Stack ID: heroku-18
    Description: The official Heroku stack based on Ubuntu 18.04
    Maintainer: Heroku
    Build Image: heroku/pack:18-build
    Run Image: heroku/pack:18

    Stack ID: io.buildpacks.stacks.bionic
    Description: A minimal Cloud Foundry stack based on Ubuntu 18.04
    Maintainer: Cloud Foundry
    Build Image: cloudfoundry/build:base-cnb
    Run Image: cloudfoundry/run:base-cnb

    Stack ID: org.cloudfoundry.stacks.cflinuxfs3
    Description: A large Cloud Foundry stack based on Ubuntu 18.04
    Maintainer: Cloud Foundry
    Build Image: cloudfoundry/build:full-cnb
    Run Image: cloudfoundry/run:full-cnb

    Stack ID: org.cloudfoundry.stacks.tiny
    Description: A tiny Cloud Foundry stack based on Ubuntu 18.04, similar to distroless
    Maintainer: Cloud Foundry
    Build Image: cloudfoundry/build:tiny-cnb
    Run Image: cloudfoundry/run:tiny-cnb

After

Stacks maintained by the community:

    Stack ID: heroku-18
    Description: The official Heroku stack based on Ubuntu 18.04
    Maintainer: Heroku
    Build Image: heroku/pack:18-build
    Run Image: heroku/pack:18

    Stack ID: io.buildpacks.stacks.bionic
    Description: A minimal Paketo stack based on Ubuntu 18.04
    Maintainer: Project Paketo
    Build Image: paketobuildpacks/build:base-cnb
    Run Image: paketobuildpacks/run:base-cnb

    Stack ID: io.buildpacks.stacks.bionic
    Description: A large Paketo stack based on Ubuntu 18.04
    Maintainer: Project Paketo
    Build Image: paketobuildpacks/build:full-cnb
    Run Image: paketobuildpacks/run:full-cnb

    Stack ID: io.paketo.stacks.tiny
    Description: A tiny Paketo stack based on Ubuntu 18.04, similar to distroless
    Maintainer: Project Paketo
    Build Image: paketobuildpacks/build:tiny-cnb
    Run Image: paketobuildpacks/run:tiny-cnb
  • Should this change be documented?
    • Yes, see #___
    • No

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #781 into main will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   74.75%   75.59%   +0.84%     
==========================================
  Files          77       77              
  Lines        5164     5197      +33     
==========================================
+ Hits         3860     3928      +68     
+ Misses        999      972      -27     
+ Partials      305      297       -8     
Flag Coverage Δ
#os_linux 78.00% <ø> (+0.79%) ⬆️
#os_macos 73.94% <ø> (+0.82%) ⬆️
#os_windows 73.87% <ø> (+0.75%) ⬆️
#unit 75.59% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dfreilich
Copy link
Member

Just to confirm - should the maintainer be Paketo Project, or Project Paketo? The website seems to refer to it as "The Paketo project"

@dfreilich dfreilich added this to the 0.13.0 milestone Aug 10, 2020
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label Aug 11, 2020
Signed-off-by: Marty Spiewak <mspiewak@pivotal.io>
@martyspiewak
Copy link
Contributor Author

@dfreilich updated the maintainer to say "Paketo Project". Thanks for catching that!

@jromero jromero merged commit 4d19631 into buildpacks:main Aug 11, 2020
@jromero jromero changed the title Reference paketo stacks in suggest-stacks Reference paketo stacks in suggest-stacks Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants