Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported platform APIs to pack report #815

Merged
merged 4 commits into from Aug 25, 2020
Merged

Add supported platform APIs to pack report #815

merged 4 commits into from Aug 25, 2020

Conversation

danielcooperxyz
Copy link
Contributor

@danielcooperxyz danielcooperxyz commented Aug 21, 2020 •
edited

Summary

Add supported platform APIs to pack report (#810)

Output

Before

$ out\pack.exe report --explicit
Pack:
  Version:  0.0.0+git-10f5f0a
  OS/Arch:  windows/amd64

  Default Lifecycle Version:  0.9.1

Config:
...

After

$ out\pack.exe report --explicit
Pack:
  Version:  0.0.0+git-10f5f0a
  OS/Arch:  windows/amd64

  Default Lifecycle Version:  0.9.1

  Supported Platform APIs:   0.3, 0.4

Config:
...

Documentation

  • Should this change be documented?
    • No

Related

Resolves #810

@danielcooperxyz danielcooperxyz requested a review from a team as a code owner August 21, 2020 10:24
@danielcooperxyz
Add supported platform APIs to pack report (buildpacks#810)
112767d 
Signed-off-by: Daniel Cooper <cooper.daniel45@gmail.com>
@danielcooperxyz
update the acceptance test report output template file
6f55535 
Signed-off-by: Daniel Cooper <cooper.daniel45@gmail.com>
@codecov
Copy link

codecov bot commented Aug 21, 2020 •
edited

Codecov Report

Merging #815 into main will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   77.76%   77.79%   +0.04%     
==========================================
  Files          79       79              
  Lines        4549     4556       +7     
==========================================
+ Hits         3537     3544       +7     
  Misses        702      702              
  Partials      310      310
Flag Coverage Δ
#os_linux 77.79% <100.00%> (+0.04%) ⬆️
#os_macos 73.89% <100.00%> (+0.05%) ⬆️
#os_windows 100.00% <ø> (ø)
#unit 77.79% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

natalieparellano
natalieparellano approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielcooperxyz thanks for the PR! This is great!

yaelharel
yaelharel approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@yaelharel yaelharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clear.
Looks great!

@danielcooperxyz
Format supported platform APIs using string join
1a41c23 
Signed-off-by: Daniel Cooper <cooper.daniel45@gmail.com>
jromero
jromero approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@jromero jromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone else took the words out of my mouth. Here's a gif:

superb

Thank you @danielcooperxyz!

@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label Aug 25, 2020
@jromero jromero added this to the 0.14.0 milestone Aug 25, 2020
@jromero jromero merged commit 6ebfc96 into buildpacks:main Aug 25, 2020
dwillist pushed a commit to dwillist/pack that referenced this pull request Sep 8, 2020
@jromero @dwillist
Merge pull request buildpacks#815 from danielcooperxyz/main
45380c0 
Add supported platform APIs to `pack report` (buildpacks#810)

Signed-off-by: dwillist <dthornton@vmware.com>
@jromero jromero changed the title Add supported platform APIs to pack report (#810) Add supported platform APIs to pack report Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjjones simonjjones simonjjones left review comments

@jromero jromero jromero approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

@yaelharel yaelharel yaelharel approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

Add supported platform APIs to pack report
5 participants
@danielcooperxyz @simonjjones @jromero @natalieparellano @yaelharel