Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print only image name (and digest) when running pack build in quiet mode #831

Merged
merged 1 commit into from Sep 17, 2020
Merged

Print only image name (and digest) when running pack build in quiet mode #831

merged 1 commit into from Sep 17, 2020

Conversation

dfreilich
Copy link
Member

@dfreilich dfreilich commented Sep 3, 2020 •
edited

  • Fetcher used to log directly to the Writer, and bypass quiet mode. This fixes that hole.
  • This implements a request (Only output full image tag or image digest from build #285) for having build -q to print the app name @ sha. It only adds it into the quiet mode; in a normal build, there's no need to print it, since the information is printed by the lifecycle. It is only in cases where we suppress that output (quiet mode) where we need to print it ourselves.

Signed-off-by: David Freilich dfreilich@vmware.com

Summary

Output

Before

image

After

image

Documentation

  • Should this change be documented?
    • No

Related

Resolves #285

@dfreilich dfreilich requested a review from a team as a code owner September 3, 2020 10:01
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited

Codecov Report

Merging #831 into main will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   77.31%   76.19%   -1.11%     
==========================================
  Files          81       81              
  Lines        4657     4141     -516     
==========================================
- Hits         3600     3155     -445     
+ Misses        728      655      -73     
- Partials      329      331       +2
Flag Coverage Δ
#os_linux 76.19% <ø> (+0.11%) ⬆️
#os_macos 72.57% <ø> (-1.60%) ⬇️
#os_windows 100.00% <ø> (ø)
#unit 76.19% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero changed the title Fix quiet mode Print only image name (and digest) when running pack build in quiet mode Sep 14, 2020
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label Sep 14, 2020
@jromero jromero added this to the 0.14.0 milestone Sep 14, 2020
@jromero
Copy link
Member

jromero commented Sep 17, 2020

🎉 LGTM

Feel free to merge once re-testing is successful

@dfreilich
Fix quiet mode
3753d11 
* Fetcher used to log directly to the Writer, and bypass quiet mode. This commit fixes that hole.
* This implements a request (#285) for having build -q to print the app name @ sha

Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich merged commit 87c62e6 into main Sep 17, 2020
@dfreilich dfreilich deleted the fix/285-quiet-tag branch September 17, 2020 20:07
@dfreilich dfreilich mentioned this pull request Jan 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

Only output full image tag or image digest from build
2 participants
@dfreilich @jromero