Allow single buildpack in multiple groups #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same id and version Signed-off-by: dwillist <dthornton@vmware.com>
dfreilich
approved these changes
Nov 6, 2020
dfreilich
changed the title
Signed-off-by: dwillist <dthornton@vmware.com>
Codecov Report
@@ Coverage Diff @@
## release/0.15.0-rc2 #938 +/- ##
======================================================
+ Coverage 76.55% 76.58% +0.04%
======================================================
Files 101 101
Lines 4984 4991 +7
======================================================
+ Hits 3815 3822 +7
Misses 772 772
Partials 397 397
Flags with carried forward coverage won't be shown. Click here to find out more. |
jromero
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a check for buildpack repetitions with the same id and version
Signed-off-by: dwillist dthornton@vmware.com
Summary
Fix a bug due to not checking if we have repeated buildpack
id&versioncombinations when validating builtpack configuration.Related
Resolves #858